Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add t8sg and devof4 #3

Closed
wants to merge 2 commits into from
Closed

Add t8sg and devof4 #3

wants to merge 2 commits into from

Conversation

vladislavy
Copy link
Contributor

I can't test it with Windows environment. So, it's suggested change for testing.

@F-D-R
Copy link

F-D-R commented Nov 27, 2017

I think "t8sg" is redundant in the transmitter definitions, if you already have ".t8sg.".
IMO it would be more appropriate to have a separate T8SG type, because now it would be recognized as a 7E...

The patterns in the Analyze method are redundant too, the ones without the "devo" prefixes would match the devo firmwares and libraries too...

@vladislavy
Copy link
Contributor Author

We can't use separate T8SG type since it has devo7e txid (0x7e).

"deviation-devo7e-v5.0.0-be57e84"
without the "devo" prefixes will be compared with
"deviation-7e-v5.0.0-be57e84"

@F-D-R
Copy link

F-D-R commented Nov 27, 2017

No, I see now where I was mistaken:

The pattern "deviation-devo([^-]+)-(\S+)\.zip" will match "deviation-devo7e-v5.0.0-be57e84.zip" and give "7e" and "v5.0.0-be57e84" as results, however the "deviation-([^-]+)-(\S+)\.zip" patter while would match with the same filename, but would give "devo7e" and "v5.0.0-be57e84" as results. Only the "else if" statement prevents to finding that, so that is fine indeed.

BTW in case of the U7E, which has a filename of "deviation-devo7e-256-v5.0.0-be57e84.zip" the results would be "7e" and "256-v5.0.0-be57e84", which is not that good, I think...

Copy link

@F-D-R F-D-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it, because it is definitely better then it was, but probably it will need some more refinements

@vladislavy vladislavy closed this Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants