devo7e-256 bugfix for original switch mod #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iginal switch mod support.
…f no pots are installed.
* u7e_5.0.0_switch_bug: Put conditionals around case statements for pots to prevent reading if no pots are installed. Clean up conditionals and syntax errors for switches due to bug in original switch mod support.
|
tested and working fine on stock 7e firmware with no switch mods, ult7e with no switchmods and ult7e with 4x3, 2x2 and 2pots |
…t lets use this for now until we actually need to fix it.
* master: Update cc2500.c Add config-cc2500 0x01 for CC2500 modules with GDO0 connected to RX_EN and GDO2 connected to TX_EN of PA/LNA. Add ability to configure modules in hardware.ini Fix [Deviation 0000704], S-FHSS freq tuning options incorrect initialization
* u7e_5.0.0_swcfg: Change case vs conditional handling to prevent ghost switches. Fix too many inputs. Need to figure out "HAS_MORE_THAN_32_INPUTS", but lets use this for now until we actually need to fix it. First commit. Still testing.
* u7e_5.0.0_swcfg: Key mapping changes First pass at updating emu with new switch configurations.
| } | ||
| } else { | ||
| if ((~Transmitter.ignore_src & SWITCH_3x1) == SWITCH_3x1) { |
There was a problem hiding this comment.
I don't like the large amount of highly repetitive code. Can you try to make it a loop over INP_SW* ?
|
Hi Victzh, I'd be glad to. Problem is, I'm not quite sure how to do that. I'm not that great a programmer. Any chance you could point me in the right direction? Thanks a lot for taking a look at this! |
* master: added protocol documentation for CX-10A/CX-10 blue
* master: (37 commits) Cleanup Fix bind Add accelerometer recalibration flag Fix emulator build Clean up Add FQ777-951 protocol format Added whitening. Improved telemetry update. Fix E010 didn't work with some transmitter ID Fix bind issue with some transmitter ID Fix headless mode Cleared top bit of rx_tx_addr[1] for easier storage in options Better check of ACK when binding Updated comments Removed bind magic numbers. Increased ARD to 2500us Changed to use single payload size. Code tidy. Improved data packet and telemetry parsing Initial commit of iNav protocol Allow semi arbitrary transmitter ID Add H301 format Fix ID and 8 channels ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for original extra switch mod in devo7e-256.