--net host is no longer needed for stf-provider #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koral--
reviewed
Jan 7, 2021
doc/DEPLOYMENT.md
Outdated
| @@ -851,7 +855,7 @@ Description=STF s3 storage | |||
| After=docker.service | |||
| Requires=docker.service | |||
|
|
|||
| [Service] | |||
| [Service]provider | |||
There was a problem hiding this comment.
Why we need a provider suffix there?
There was a problem hiding this comment.
I think that was a typo on my part--computer was crashing (Mac's kernel_task taking up 18000% CPU...)
newer versions of Docker now support exposing port ranges, so we no longer need to use `--net host`. Respective docker networking changes for ADB are included. Signed-off-by: Pete Myron <pete.myron@t-mobile.com>
fixed typo Signed-off-by: Pete Myron <pete.myron@t-mobile.com>
petemyron
force-pushed
the
remove-net-host-from-stf-provider
branch
from
f51e902
to
598a240
Compare
koral--
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newer versions of Docker now support exposing port ranges, so we no longer need to use
--net host. Respective docker networking changes for ADB are included.