Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcode download URLs #5

Merged
merged 1 commit into from
May 9, 2018
Merged

Hardcode download URLs #5

merged 1 commit into from
May 9, 2018

Commits on Apr 21, 2018

  1. Hardcode download URLs 

    When working on cucumber/cucumber-rails#378, we would sometimes see that the builds would be unable to connect to the Geckodriver. On further investigation, this seems to be caused by the Geckodriver not being downloaded in the first place. I think that this is due to GitHub's API rate limiting certain build machines from accessing their API.

A better approach would be to hardcode the URLs for the assets -- since they're easily predicatable -- and then to bump this gem whenever a new release comes out.
    Ryan Bigg committed Apr 21, 2018
    Configuration menu
    Copy the full SHA
    940b353 View commit details
    Browse the repository at this point in the history