Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/Linux: Build AppImage on Ubuntu 22.04 (Python 3.10) #423

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

guihkx
Copy link
Contributor

@guihkx guihkx commented Jan 22, 2024

Ubuntu 20.04 only has Python 3.8, and because the truststore dependency requires at least Python 3.10, the AppImage package would need to bundle CA certificates from certifi to make HTTPS requests work at all, which is quite an ugly workaround.

Unfortunately, as a side effect, building on Ubuntu 22.04 increases the minimum required version of glibc from 2.31 to 2.35.

Closes #421

This makes the app start slightly faster, as byte-code files won't need
to be generated every time users run the app.

https://docs.python.org/3.10/library/compileall.html
Ubuntu 20.04 only has Python 3.8, and because the 'truststore'
dependency requires at least Python 3.10, the AppImage package would
need to bundle CA certificates from 'certifi' to make HTTPS requests
work at all, which is quite an ugly workaround.

Unfortunately, as a side effect, building on Ubuntu 22.04 increases the
minimum required version of glibc from 2.31 to 2.35.
@DevilXD DevilXD added Enhancement New feature or request Fix This fixes an existing issue or error labels Jan 22, 2024
@DevilXD
Copy link
Owner

DevilXD commented Jan 22, 2024

Yeah, I wanted to avoid having to bundle anything, if truststore can make it work instead too. Also, regarding file size, building from a virtual environment (venv) like I normally do during local development (setup_env.bat, etc.), seems to help limit the amount of "extra" libraries that'll get packed into the image, at least with PyInstaller. Not sure how AppImage chooses it's files to include.

Everything looks good! Thank you for your help =)

@DevilXD DevilXD merged commit 8bc62dc into DevilXD:master Jan 22, 2024
4 checks passed
@guihkx
Copy link
Contributor Author

guihkx commented Jan 23, 2024

No problem! ^^

Not sure how AppImage chooses it's files to include.

Unfortunately, with AppImage, for the most part we have to do the inclusion and deletion of everything by ourselves... :(

@guihkx guihkx deleted the appimage-python3.10 branch January 23, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Fix This fixes an existing issue or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppImage useability verification
2 participants