Fix building of Linux AppImage / automated uploads to the Releases page #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version bump is now needed because of changes from commit 7e2c233, which ended up breaking automated uploads to the Releases page.
This fixes the broken "Linux (AppImage)" CI job. PyGObject 3.47 has dropped setuptools in favor of meson-python, which isn't a problem per se, but they also require meson 0.63.3, which we don't currently have in the repositories of Ubuntu 20.04, which is the oldest (yet supported) version we use to build our AppImage package, in order to increase compatibility with as much Linux distros as possible. And since there's no real, compelling reason to upgrade to the latest version of PyGObject right now, let's just pin it to version <3.46, until we eventually upgrade the Ubuntu version we use for CI.
|
Great! Thank you for this 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits:
CI: Update
actions/download-artifacttov4:This version bump is now needed because of changes from commit 7e2c233, which ended up breaking automated binaries uploads to the Releases page.
Linux: Pin
PyGObjectversion to<3.47:This fixes the broken
Linux (AppImage)CI job.PyGObject 3.47 has dropped setuptools in favor of meson-python, which isn't a problem per se, but they also require meson 0.63.3, which we don't currently have in the repositories of Ubuntu 20.04, which is the oldest (yet supported) version we use to build our AppImage package, in order to increase compatibility with as much Linux distros as possible.
And since there's no real, compelling reason to upgrade to the latest version of PyGObject right now, let's just pin it to version
<3.47, until we eventually upgrade the Ubuntu version we use for CI.