Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer and PSR-2 refactoritzation #582

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

albeertito7
Copy link

Added Composer so that this project can be based on namespaces and dependencies, enabling more complex solutions. Also, applied the PHP PSR-2 coding standard.

Plugin tested on local environment.

@75th
Copy link

75th commented Feb 1, 2023

I don't think this goes far enough. Instead of PluginName/Includes/PluginNameActivator, you could just have PluginName/Activator. I've got a branch in progress that does that, along with some reorganization to have traditional plugin stuff live alongside custom Gutenberg blocks, etc.

@75th
Copy link

75th commented Feb 1, 2023

(...and now that branch activates cleanly in WordPress.)

@albeertito7
Copy link
Author

I don't think this goes far enough. Instead of PluginName/Includes/PluginNameActivator, you could just have PluginName/Activator. I've got a branch in progress that does that, along with some reorganization to have traditional plugin stuff live alongside custom Gutenberg blocks, etc.

you can definitely organize your namespace as you wish of course, this is just a guide for those who want to orient themselves in this schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants