This repository has been archived by the owner on May 24, 2022. It is now read-only.
Refactor "ApiDocController" #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add integration test for ApiDocContoller - Refactor Service and TableMeta data access into repositories - Update PHP version requirement to ^7 - Add Doc block to all modified files - Set timestamps attribute of TableMeta model to false - Bind the Repository interfaces to the respective implementation to the Dependency Injection Container at the AppServiceProvider's register method. - Change travis PHP requirement to 7.1.1 Signed-off-by: Paul Karikari <paulkarikari1@gmail.com>
|
All good and tests pass nicely @koficodes |
paulkarikari
added a commit
to paulkarikari/DV-PHP-CORE
that referenced
this pull request
Jun 11, 2018
- Add test to "getSchema" and "getTableMetaByServiceId" methods of "TableMetaRepository" class. - Add test to "getAll" method of "ServiceRepository" class. - Fix typo in "ApiDocController" doc block (see PR DevlessTeam#96) Signed-off-by: Paul Karikari <paulkarikari1@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to the Dependency Injection Container at the AppServiceProvider's
register method.
Signed-off-by: Paul Karikari paulkarikari1@gmail.com