Skip to content
This repository has been archived by the owner on Jul 19, 2022. It is now read-only.

Wrong font in State of CSS 2021 screenshot #10

Closed
foolip opened this issue Dec 16, 2021 · 2 comments
Closed

Wrong font in State of CSS 2021 screenshot #10

foolip opened this issue Dec 16, 2021 · 2 comments

Comments

@foolip
Copy link

foolip commented Dec 16, 2021

I'm pretty sure this is the wrong repo, but can't find the right repo.

https://stateofx-images.netlify.app/captures/css2021/en-US/grid.png is linked from https://2021.stateofcss.com/en-US/features/layout and looks like this:
image

The font for the title looks like the standard serif font, maybe the webfont for the titles wasn't loaded when this screenshot was taken?

I'm not sure if it affects any other screenshots too.

If this is done with a Puppeteer script or similar, then in addition to waiting for the load event, consider await document.fonts.ready before the screenshot. (But start awaiting after the load event. It's complicated.)

@foolip
Copy link
Author

foolip commented Dec 16, 2021

I noticed this in GoogleChrome/web.dev#7062.

@SachaG
Copy link
Member

SachaG commented Dec 17, 2021

I think this is because I hadn't defined a proper fallback for code, it should be good now. Just need to regenerate everything.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants