Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

With these updates, RTL support is also available for locales. #89

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

fghamsary
Copy link
Contributor

As I've already said in the VulcanJS/Vulcan#2670 the Vulcan were not really RTL friendly.
I just added a PR which is working with this one as well.
The latest code of Vulcan with my modifications should be used for the compilation of this project to work.
Basically this is support for RTL locale and adding my name :p for the Persian translation.
This helped me to debug and add the Persian translation, which will be another PR to the API (graphql) part as well.
Hope that this one is good as well.
PS: I had to hack and change the styles in the bootstrap file, so it's not the standard bootstrap as the standard bootstrap 4.x doesn't support RTL.
The only change that I've made was adding a new CSS property which is used for rtl/ltr (start) of text-align in general parts.

Please do not hesitate to tell me if anything is wrong with my code.

Thanks in advance :)

@SachaG
Copy link
Member

SachaG commented Dec 14, 2020

Thanks so much! It's great to have RTL support, can't wait to try it out :)

@SachaG SachaG merged commit 122dfc0 into Devographics:master Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants