New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbedtls: mutex initialisation on Windows #1

Merged

awakecoding merged 1 commit into wayk from wayk-threading

Jan 9, 2019

Member

thenextman commented Jan 9, 2019

Change threading_mutex_init_windows to match threading_mutex_init_pthread behaviour (https://github.com/Devolutions/mbedtls/blob/development/library/threading.c#L71).

The check of mutex->is_valid is not valid (!) because the mutex parameter may not have been initialized yet.

This can crash us e.g. when initializing entropy

Alternative fix would be here: https://github.com/Devolutions/mbedtls/blob/development/library/entropy.c#L68. We could zero the entire ctx instead of ctx->source.


          mbedtls: mutex initialisation on Windows

c5d1923

thenextman requested a review from awakecoding

January 9, 2019 18:10

awakecoding approved these changes

View reviewed changes

awakecoding left a comment

LGTM

awakecoding merged commit 7a83a31 into wayk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment