Replace ring ecdsa implementation with rust cryptos #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xynnn007
force-pushed
the
refactor-replace-ring
branch
2 times, most recently
from
e60725a
to
89d7dca
Compare
|
Update: delete |
flavio
reviewed
Feb 28, 2023
Xynnn007
force-pushed
the
refactor-replace-ring
branch
from
89d7dca
to
6f88c6c
Compare
Replaced `ring` elliptic curve signature implementations with RustCrypto Added a compability test for previous ring implementation and current rust crypto to ensure the functionality of API does not change Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Xynnn007
force-pushed
the
refactor-replace-ring
branch
from
6f88c6c
to
cea3944
Compare
|
Thanks for adopting this! @CBenoit When could this PR be included in the next release? |
I’ll take some time to publish a new version next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm working on the downstream crates and find that the
ringcrate used in this crate cannot be compiled in archs390x. Thus I summit this PR to replace theringwith RustCrypto to implement Elliptic Curve Signatures.Please take a look if I did anything contrary to the design of this module. Thanks!
Main change
ringelliptic curve signature implementations with RustCryptocc @flavio who is the initial writer of the related code