Double Convolution #435
Merged
Double Convolution #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add the specialization for <Box, Box>.
… CDiracImageFilterKernel.
…enRegionsImageFilter (still doesn't seem to work on BC formats, though).
…ome fixes from ditt.
…eBlit when updating it to work with DLT changes.
…leImageFilterKernel.h
Also make evalImpl protected
…nnelIndependentWeightFunctionOfConvolutions concept
…into double_convolution
|
/execute order 0x45ull |
|
/execute order 0x45ull |
|
/execute order 0x45ull |
…unt validation check to CBlitImageFilter, update all onDecode implementations - remove encode buffer, do swizzle on input decode buffer in-place and respect channel count, update all onDecode references, make sure all compiles
|
/execute order 0x45ull |
include/nbl/asset/filters/CSwizzleableAndDitherableFilterBase.h
Outdated
Show resolved
Hide resolved
…mming/Nabla into double_convolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have:
the following kernels:
Kernel modifiers allow you to create a new kernel as a modifications of the above kernels.
Currently we have the following 4 kernel modifiers:
After removing
CScaledImageFilterKernel, we will be eliminating the first one.To eliminate the Scaling & Stretching modifier, means to make scaling and stretching an inherent property of the filter kernels.
TODO
conceptfor blittable kernels.CScaledImageFilterKernel.dittbranch. Check this private Discord link.