Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG REPORT] Unintended Default Faderbank Voltage Range? #184

Closed
VegaDeftwing opened this issue Oct 2, 2023 · 3 comments
Closed

[BUG REPORT] Unintended Default Faderbank Voltage Range? #184

VegaDeftwing opened this issue Oct 2, 2023 · 3 comments

Comments

@VegaDeftwing
Copy link

** Platform/Version **

  • OS version: Win11
  • Rack version: Pro 2.4.1
  • Plugin version: 2.2.2

Describe the bug
The fader voltage range defaults to 0-10V in the right-click menu, but actually outputs +/-10V. If you change it to any other mode and then select 0-10V, it's actually 0-10V, making it impossible to return to the +/-10V mode it's in by default.

@VegaDeftwing
Copy link
Author

Bug seems to be from

configParam(i, -10.0, 10.0, 0.0, rack::string::f("Fader %d", i + 1), " V");
setting the range to +/-10 but then not calling FaderbankModule::updateFaderRanges() on load?

@Dewb
Copy link
Owner

Dewb commented Oct 2, 2023

Thanks for writing this up, I noticed this yesterday as well. The expanded default range was a last-minute fix to problems caused by the fact that Rack deserializes params before it deserializes custom module properties, and I didn't check that it worked correctly for newly placed module instances!

@Dewb
Copy link
Owner

Dewb commented Oct 3, 2023

Fixed in 2.2.3: https://github.com/Dewb/monome-rack/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: v2.2.x (2023-09-21)
Development

No branches or pull requests

2 participants