Skip to content

Commit

Permalink
Update ERC223_interface.sol
Browse files Browse the repository at this point in the history
  • Loading branch information
@Dexaran
Dexaran committed Dec 25, 2017
1 parent 2764c14 commit 4b21591
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion token/ERC223/ERC223_interface.sol
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ contract ERC223Interface {
function balanceOf(address who) constant returns (uint);
function transfer(address to, uint value);
function transfer(address to, uint value, bytes data);
event Transfer(address indexed from, address indexed to, uint value, bytes indexed data);
event Transfer(address indexed from, address indexed to, uint value, bytes data);
}

1 comment on commit 4b21591

@quezak
Copy link

@quezak quezak commented on 4b21591 Feb 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dexaran on the Recommended branch the last event's argument is still indexed, but here you removed the index, and this change is newer than the Recommended interface. Can you explain why? is/will this be the new recommended way?

Using indexed on a variable length datatype crashes the event decoder in web3.js (see issue on truffle, issue on web3.js), was that your reason for the change?

Please sign in to comment.