-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating individual plugins for core plugins #126
Comments
Open for discussions as I previously had core plugins externalized from the app. I bundled it into core since a lot of users expected the general functionalities available as part of the app. |
That's a fair point, since it would be confusing for a lot of users if the core app can't do any of the things advertised. Instead how about having a configuration file that would automatically download and update apps and etc? E.g
essentially something similar to vim's plugin management (if you've used that before), or even a lot like npm package.json files. Then we can supply a default configuration with all the "core" plugins listed so that the functionality comes out of the box, but is still developed separately? Just seems like the best of both worlds in my opinion |
I like that idea. Currently, we do have a way to manage plugins via the |
It seems that the config.json already has support for keeping track of plugins, we simply need to add a built in packagement management tool for dext so that it can read the config file and auto install / update? |
We do have an external CLI tool here and I'm currently working on building an internal plugin that interfaces with this within the dext bar itself. |
I want to pick this issue up again. Now that we are splitting up some of the core plugins into external packages, we'll need a way for Dext to automatically download and install pre-packaged plugins that is found in the |
Just a thought: EDIT: Actually after reading this thread again maybe that's what @z3t0 meant in this comment 🙊 |
I must have misinterpreted the original issue but I think what @z3t0 is referring to is an option for the app to automatically check and install plugins that are listed in the ~/.dext/config.json` file similar to how Hyper works. Ways I can see this being beneficial for Dext:
I really do think this is great idea and to expand on it, we can namespace all core plugins on npm as scoped packages (eg: |
Oh my, I think I've misinterpreted it then :) This all makes sense. I think this bit mislead me.
That's why I thought about having separate NPM packages for them, which I still think could be interesting but may be out of this issue's scope. |
not sure if this is the right thread to put this in, but I heard settings window mentioned so I made one with react/redux/radium and served by electron. It's a bit barebones right now, but what is there should work, and adding new features shouldn't be too difficult. |
Hey guys, I'm going to close this issue for a handful, some obvious reasons:
As of this moment, this proposal (also my draft for dext) is interchangable, and I welcome suggestions, feedback and thoughts. For now, to do this effectively, create a new issue on this repo with the draft as reference. I highly encourage this approach, to avoid noise on the gist ref: https://gist.github.com/adnasa/fec7c66d39f700371262437bb22732ad#lerna |
Is there any particular reason for having "core" plugins? In my opinion it would be easier to maintain them if they were separate. Also, those only interested in a particular feature would find it easier to say work on the screenshot plugin if it was its own project.
Thoughts?
The text was updated successfully, but these errors were encountered: