Easier to set temp dir, and all temp files are unlinked after use #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @andris9 ? |
|
Sorry, somehow went unnoticed. Thanks! |
andris9
added a commit
that referenced
this pull request
Feb 25, 2014
Easier to set temp dir, and all temp files are unlinked after use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Andris, thanks for 'pem'. I noticed that the existing fs.unlink at the end of each openssl call wasn't actually doing anything. This PR makes it so all the temp files actually get removed.
I also added an environment variable, PEMJS_TMPDIR, that lets you set a separate temp directory for pem from the global node.js one.
Cheers,
Anand