Version 0.2 #9
Merged
Version 0.2 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
XedinUnknown
commented
Sep 24, 2017
XedinUnknown
commented
- Fixed a problem where type used in doc was not imported.
- Context renderer is now a template.
- Template-aware interface added.
Imported Stringable Type
Made Templating Explicit
mecha
approved these changes
Sep 25, 2017
There was a problem hiding this comment.
LGTM. Remember to update the changelog and since tags.
Furthermore, I would also change the since tags for anything that was involved in the template rename to 0.2, since they are completely new elements in the API (even if forged out of existing elements).
TemplateInterfaceand all methods and testsTemplateRenderExceptionInterfaceand all methods and tests
mecha
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.