-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Quantum Infinity configurator #496
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavoutich
changed the title
add Quantum Infinity configurator
WIP: add Quantum Infinity configurator
Aug 16, 2018
Pull Request Test Coverage Report for Build 3750
💛 - Coveralls |
AdriaanRol
approved these changes
Aug 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Feel free to merge
slavoutich
force-pushed
the
task/quantuminfinity_config
branch
from
August 21, 2018 16:45
df93782
to
1d70411
Compare
slavoutich
changed the title
WIP: add Quantum Infinity configurator
Add Quantum Infinity configurator
Aug 21, 2018
Closed
slavoutich
force-pushed
the
task/quantuminfinity_config
branch
from
August 21, 2018 16:53
1d70411
to
08552f1
Compare
AdriaanRol
approved these changes
Aug 28, 2018
slavoutich
force-pushed
the
task/quantuminfinity_config
branch
from
August 30, 2018 11:54
9656aab
to
95dc4d6
Compare
The following commands are defined now. Any opinion to adjust them?
|
1. Less dots (`rot_0.0_90.0` -> `rot_0_90`) 2. All instructions now are argumentless (OpenQL supports only `codeword qX` style. 3. Minor cleanup.
slavoutich
force-pushed
the
task/quantuminfinity_config
branch
from
August 30, 2018 12:08
95dc4d6
to
3508889
Compare
@AdriaanRol Now QASM looks good and should work with OpenQL. If you review now, I will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AdriaanRol Please take a look.