Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cz flux arc fix #497

Merged
merged 27 commits into from
Aug 30, 2018
Merged

Cz flux arc fix #497

merged 27 commits into from
Aug 30, 2018

Conversation

AdriaanRol
Copy link
Contributor

Radical changes to the CZ flux pulses, made with @FKMalina .

Please do not merge, this is mostly there so I have access to a convenient diff with develop.

@coveralls
Copy link

coveralls commented Aug 29, 2018

Pull Request Test Coverage Report for Build 3744

  • 536 of 541 (99.08%) changed or added relevant lines in 6 files are covered.
  • 88 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.04%) to 35.223%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pycqed/tests/test_mw_lutman.py 100 101 99.01%
pycqed/tests/test_flux_lutman.py 241 243 99.18%
pycqed/instrument_drivers/meta_instrument/LutMans/flux_lutman.py 119 121 98.35%
Files with Coverage Reduction New Missed Lines %
pycqed/measurement/waveform_control_CC/qasm_compiler.py 1 82.83%
pycqed/measurement/waveform_control_CC/waveform.py 3 83.02%
pycqed/measurement/waveform_control_CC/qasm_compiler_helpers.py 8 74.16%
pycqed/instrument_drivers/meta_instrument/LutMans/flux_lutman.py 14 77.3%
pycqed/measurement/waveform_control_CC/QWG_fluxing_seqs.py 23 10.94%
pycqed/measurement/sweep_functions.py 39 22.63%
Totals Coverage Status
Change from base Build 3708: -0.04%
Covered Lines: 20102
Relevant Lines: 57071

💛 - Coveralls

@AdriaanRol
Copy link
Contributor Author

Everything is implemented, @FKMalina is using it now in experiment.
I will write some more tests to ensure everything is working as expected and plot some figures below of the plotting methods (that still need to be updated).

@AdriaanRol
Copy link
Contributor Author

Images generated by the flux lutman on demand now.

image
image

@fbattistel
Copy link
Contributor

I've realized that the bug was not affecting the final result because we take the ratio t/scale afterwards

@AdriaanRol
Copy link
Contributor Author

Hi @fbattistel , I'm assuming you are OK with the changes but could you (for the sake of protocol) hit the approve button?

You can find it in the review changes button in the "files changed" tab.
screenshot 2018-08-30 13 40 57

Please do not merge yet, this is typically done by whoever opened the pull request (PR).

@AdriaanRol AdriaanRol merged commit c767104 into develop Aug 30, 2018
@AdriaanRol AdriaanRol deleted the CZ_flux_arc_fix branch September 10, 2018 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants