-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cz flux arc fix #497
Cz flux arc fix #497
Conversation
Pull Request Test Coverage Report for Build 3744
💛 - Coveralls |
Everything is implemented, @FKMalina is using it now in experiment. |
it was wrong the integration step to convert from virtual time to physical time
I've realized that the bug was not affecting the final result because we take the ratio t/scale afterwards |
Hi @fbattistel , I'm assuming you are OK with the changes but could you (for the sake of protocol) hit the approve button? You can find it in the review changes button in the "files changed" tab. Please do not merge yet, this is typically done by whoever opened the pull request (PR). |
Radical changes to the CZ flux pulses, made with @FKMalina .
Please do not merge, this is mostly there so I have access to a convenient diff with develop.