Configurable paths, ppl; prevent log2(0) #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the parameters ppl and paths configurable via the wrapper function exponential_decay_correction_hw_friendly. Prevent taking the logarithm of 0. If the coefficient is zero, then the bit shift (bshift) does not matter (can be set to zero).
AdriaanRol
approved these changes
Sep 20, 2018
Pull Request Test Coverage Report for Build 3879
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AdriaanRol: here are some small improvements of the precompensation models, which I made for my most recent simulations. The parameter ppl is now controlled via the wrapper function exponential_decay_correction_hw_friendly. There should be no change of the behavior of the functions as long as the default settings ppl = 2 and paths =8 are used.
In addition, I prevent a warning by avoiding taking the log2 of zero.