Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to scala-logging Library #131

Closed
abo64 opened this issue Jun 24, 2015 · 10 comments
Closed

Upgrade to scala-logging Library #131

abo64 opened this issue Jun 24, 2015 · 10 comments

Comments

@abo64
Copy link

abo64 commented Jun 24, 2015

We cannot really use pact-jvm due to your usage of the obsolete (dead would probably be the more appropriate description) scalalogging library.
Is it possible to upgrade to scala-logging?

@uglyog
Copy link
Member

uglyog commented Jun 24, 2015

Sure, I'll add in a hyphen for you.

@uglyog
Copy link
Member

uglyog commented Jun 25, 2015

I'm unable to update the project as there is no scala-logging artifact for scala 2.10. There is only one for 2.11.

@abo64
Copy link
Author

abo64 commented Jun 25, 2015

Hmm, you've got a point here. Well then, I have to find some way around my problems.
But please remember this issue once you abandon Scala 2.10.

Thanks,
Achim.

@uglyog
Copy link
Member

uglyog commented Jun 25, 2015

What problems are you having? As far as I can see, it is just a rename of the repository and a different base package.

@abo64
Copy link
Author

abo64 commented Jun 25, 2015

Our (gradle) projects all use the new scala-logging library. So far we did not manage to avoid the conflicts resulting.
But perhaps I have to just try harder and dive deeper into gradle's dependency management or so.

@uglyog
Copy link
Member

uglyog commented Jun 25, 2015

It is only 3 classes, so I could inline them and that should not cause a conflict with your project

@abo64
Copy link
Author

abo64 commented Jun 25, 2015

That sounds like a great idea.
Thanks so much!

@uglyog
Copy link
Member

uglyog commented Jun 26, 2015

Logging in-lined, should not conflict with your project now.

@abo64
Copy link
Author

abo64 commented Jun 26, 2015

Again, thanks a lot!

@uglyog
Copy link
Member

uglyog commented Jul 2, 2015

version 2.2.6 released with this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants