Turn on basic auth?

[liamawhite]

I've had a look through this repo and the actual broker repo and can't seem to find instructions to turn on basic auth and set the credentials for the broker (as opposed to the database user/pass). I am guessing its going to be something to do with pact_broker/config.ru?

[bethesque]

@mefellows we'll need to do a code change for this as per https://github.com/bethesque/pact_broker/blob/master/example/basic_auth/config.ru#L7

We can make it configurable based on the presence of the environment vars, eg

if ENV['PACT_BROKER_USERNAME']
  use Rack::Auth::Basic, "Restricted Area" do |username, password|
    username == ENV['PACT_BROKER_USERNAME'] and password == 
  ENV['PACT_BROKER_PASSWORD']
  end
end

[mefellows]

Yeah I think something like that would be ideal. Potentially down the track there could be a way to pass in a configuration file (similar to an Apache .htaccess file) so that it's not a single all-knowing user.

Long term, we would look at OAuth/SAML etc. But this will probably more appropriately live in pact.dius.com.au.

[bethesque]

Agreed, it's a short term quick fix solution. We need to put proper auth into the hosted ones.

[bethesque]

Question - should the basic auth apply to the healthcheck URL?

[mefellows]

Good question. My initial thoughts are to make it unauthenticated.

…

On Wed, May 3, 2017 at 7:50 PM, Beth Skurrie ***@***.***> wrote: Question - should the basic auth apply to the healthcheck URL? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#32 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADSjN1GBZ_xFG2buSLG6y6nr7j1vnIzks5r2E3WgaJpZM4NOBLb> .

-- Matt Fellows - http://www.onegeek.com.au/

[bethesque]

It was too fiddly! Everything is basic authed, or not for now.

eb89b61