Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optimise attenuation scan #97

Closed
wants to merge 28 commits into from

Conversation

olliesilvester
Copy link
Collaborator

@olliesilvester olliesilvester commented Jun 15, 2023

Adds functionality to devices to allow for the attenuation_optimisation_plan, for #105

This uses the changes in #94 and #90

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #97 (43b775f) into main (7cadcd9) will increase coverage by 0.58%.
The diff coverage is 94.73%.

❗ Current head 43b775f differs from pull request most recent head 87ea41b. Consider uploading reports for the commit 87ea41b to get more accurate results

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   88.51%   89.10%   +0.58%     
==========================================
  Files          56       57       +1     
  Lines        1881     1973      +92     
==========================================
+ Hits         1665     1758      +93     
+ Misses        216      215       -1     
Impacted Files Coverage Δ
src/dodal/devices/zebra.py 95.03% <68.75%> (+2.17%) ⬆️
src/dodal/devices/xspress3_mini/xspress3_mini.py 97.29% <85.71%> (-1.22%) ⬇️
src/dodal/devices/status.py 94.73% <87.50%> (-5.27%) ⬇️
src/dodal/beamlines/i03.py 88.70% <100.00%> (+1.20%) ⬆️
src/dodal/devices/areadetector/plugins/MJPG.py 97.14% <100.00%> (+0.08%) ⬆️
src/dodal/devices/attenuator.py 100.00% <100.00%> (ø)
src/dodal/devices/detector.py 86.48% <100.00%> (ø)
src/dodal/devices/eiger.py 99.31% <100.00%> (+<0.01%) ⬆️
src/dodal/devices/oav/grid_overlay.py 100.00% <100.00%> (ø)
src/dodal/devices/oav/oav_detector.py 96.15% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DominicOram
Copy link
Contributor

This is useful to have for testing the Artemis PR but I think we should get #90 and #94 merged, then make a new branch that has any additional changes on it for artemis 701

@olliesilvester olliesilvester changed the title Artemis 701 do optimise attenuation scan Add optimise attenuation scan Jun 22, 2023
@olliesilvester olliesilvester force-pushed the artemis_701_do_optimise_attenuation_scan branch 2 times, most recently from 43b775f to 87ea41b Compare June 27, 2023 13:02
@olliesilvester
Copy link
Collaborator Author

Moved PR to new branch: #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants