Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move arming the eiger out of stage #262

Closed
DominicOram opened this issue Oct 10, 2022 · 6 comments · Fixed by #631
Closed

Move arming the eiger out of stage #262

DominicOram opened this issue Oct 10, 2022 · 6 comments · Fixed by #631
Assignees

Comments

@DominicOram
Copy link
Collaborator

DominicOram commented Oct 10, 2022

As documented on the bluesky wiki stage is not expected to take a meaningful amount of time. Bluesky therefore waits on any stage being complete before continuing. Arming the detector takes ~6s and we currently do it in the stage, we should move it out of the stage so that we can do other things concurrently.

Acceptance Criteria

  • Staging the eiger takes little time
  • Starting to arm the detector can be done in parrallel with other tasks
  • The staging/arming are done as soon as possible in the plan
@bentom08
Copy link
Contributor

Just to note here - if we move the detector arm outside the stage method, the rest of the Eiger stage will still need to be completed before we start arming. If we want to save time, at best we can start staging the Eiger immediately so we can begin arming as soon as possible as well.

@DominicOram
Copy link
Collaborator Author

DominicOram commented Oct 14, 2022

Yes, I think we should do the following:

  • Split the stage in the eiger into two:
    1. Setting up for the arm, e.g. check stale params etc. (everything that needs to be done before the arm)
    2. Doing the arm (can probably stay in the stage)
  • We should then do 1. concurrently as that takes more time compared to 2.
  • We need to make sure we're waiting on 1. to finish before we actually do the stage though

@evalott100 evalott100 self-assigned this Oct 18, 2022
evalott100 added a commit that referenced this issue Oct 20, 2022
…Made the pre arming step run in a new thread in the fgs plan #262
evalott100 added a commit that referenced this issue Oct 20, 2022
…Made the pre arming step run in a new thread in the fgs plan #262
@evalott100
Copy link
Contributor

I wasn't sure if the seperation in the above commit is what we're looking for. The arm is the only thing in the stage function, everything before is contained in the new pre_arm function, which is ran in a new thread in the fast grid scan plan

@DominicOram
Copy link
Collaborator Author

I'm going to move this back into To Do as I think it a chat as a group and some further thought

@DominicOram
Copy link
Collaborator Author

Suggestion from @callumforrester stage/unstage should arm/disarm if not already in that state.

@DominicOram
Copy link
Collaborator Author

Odin currently assumes that frames are coming in very soon after arming. This could be a bad assumption.

@olliesilvester olliesilvester self-assigned this Apr 20, 2023
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue May 5, 2023
olliesilvester pushed a commit to DiamondLightSource/dodal that referenced this issue May 9, 2023
rtuck99 pushed a commit that referenced this issue Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants