-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move arming the eiger out of stage #262
Comments
Just to note here - if we move the detector arm outside the stage method, the rest of the Eiger stage will still need to be completed before we start arming. If we want to save time, at best we can start staging the Eiger immediately so we can begin arming as soon as possible as well. |
Yes, I think we should do the following:
|
…Made the pre arming step run in a new thread in the fgs plan #262
…Made the pre arming step run in a new thread in the fgs plan #262
I wasn't sure if the seperation in the above commit is what we're looking for. The arm is the only thing in the |
I'm going to move this back into |
Suggestion from @callumforrester |
Odin currently assumes that frames are coming in very soon after arming. This could be a bad assumption. |
As documented on the bluesky wiki
stage
is not expected to take a meaningful amount of time. Bluesky therefore waits on any stage being complete before continuing. Arming the detector takes ~6s and we currently do it in thestage
, we should move it out of thestage
so that we can do other things concurrently.Acceptance Criteria
The text was updated successfully, but these errors were encountered: