Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Signify on synchweb pin too long/short due to pin detect #824

Closed
DominicOram opened this issue Jul 21, 2023 · 8 comments · Fixed by #1502
Closed

Signify on synchweb pin too long/short due to pin detect #824

DominicOram opened this issue Jul 21, 2023 · 8 comments · Fixed by #1502
Assignees

Comments

@DominicOram
Copy link
Collaborator

After #499 we will not be doing a grid scan at all if the pin is too/short long and so not registering a grid collection in ispyb. Previously when the pin was too long/short we signified this to the user by putting the grid collection in ispyb with an error state and a comment saying the error. Given that we're not registering a grid at all now we need a different way of informing the user.

Acceptance Criteria

  • On pin too long/short there is a clear indication to the user in synchweb
@DominicOram
Copy link
Collaborator Author

The first place to try putting it is the rotation collection comment but this will require some GDA work. Ultimately we will skip the rotation as well so it might be better to put it in the robot load?

@DominicOram
Copy link
Collaborator Author

  • Talk to synchweb if there are other ways to do this - define an experiment kind called error? Maybe @ndg63276 can help

@ndg63276
Copy link

The RobotAction table has a status field, which can be WARNING, might be the most suitable.

@DominicOram
Copy link
Collaborator Author

Hmm... That doesn't feel great because it's not really an issue with the robot load but a subsequent issue. Might be the simplest solution for now though

@DominicOram
Copy link
Collaborator Author

#996 is related

@DominicOram
Copy link
Collaborator Author

In the latest version we should get an error on the XRC entry. Confirm this and close the issue if we do.

@DominicOram DominicOram changed the title Signify on synchweb pin too long/short due to pin detect Confirm that we are signify on synchweb pin too long/short due to pin detect Jun 24, 2024
@DominicOram DominicOram changed the title Confirm that we are signify on synchweb pin too long/short due to pin detect Confirm that we are signifying on synchweb pin too long/short due to pin detect Jun 28, 2024
@dperl-dls
Copy link
Collaborator

  • this basically just means adding to the ispyb comment on pin too long/short
  • we may get this for free?
  • work here is to confirm it is working; if it isn't, do it

we think small

@DominicOram DominicOram self-assigned this Jul 23, 2024
@DominicOram
Copy link
Collaborator Author

We do not currently get this for free as the warning comes out of pin tip detection and we don't add the callback until we send GRID_DETECT_AND_DO_GRIDSCAN later. To fix we probably want to move GRID_DETECT_AND_DO_GRIDSCAN to earlier

@DominicOram DominicOram removed their assignment Jul 23, 2024
@DominicOram DominicOram changed the title Confirm that we are signifying on synchweb pin too long/short due to pin detect Signify on synchweb pin too long/short due to pin detect Jul 23, 2024
@rtuck99 rtuck99 self-assigned this Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
4 participants