Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more objectmodel stuff #38

Merged
merged 3 commits into from Jul 23, 2018
Merged

more objectmodel stuff #38

merged 3 commits into from Jul 23, 2018

Conversation

Anthchirp
Copy link
Contributor

  • Generate documentation for model object properties
  • Expose data collection status field

@Anthchirp
Add helper function to quickly create a list of model properties
2f9864a
@Anthchirp
Use new helper function to generate properties
64ff19f 
With this the generated properties will show up in the documentation at
https://ispyb.readthedocs.io/en/latest/api.html

Fixes #35.

Also exposes data collection status field, which resolves SCI-7575.
@coveralls
Copy link

coveralls commented Jul 9, 2018 •
edited

Coverage Status

Coverage decreased (-0.1%) to 79.565% when pulling f4c9e22 on objectmodel into d2792d7 on master.

KarlLevik
KarlLevik approved these changes Jul 23, 2018
View reviewed changes
Copy link
Member

@KarlLevik KarlLevik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Anthchirp Anthchirp merged commit 6ba1272 into master Jul 23, 2018
@Anthchirp
Copy link
Contributor Author

Thanks

@Anthchirp Anthchirp deleted the objectmodel branch August 30, 2018 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarlLevik KarlLevik KarlLevik approved these changes

Assignees

@KarlLevik KarlLevik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Anthchirp @coveralls @KarlLevik