Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up basic pre-commits #77

Merged
merged 2 commits into from
May 9, 2019
Merged

Set up basic pre-commits #77

merged 2 commits into from
May 9, 2019

Conversation

Anthchirp
Copy link
Contributor

  • black (source code formatting)
  • syntax validation
  • basic flake8 checks

Add an entry point to enable pre-commits if the package is installed
in a dials environment.

You'll have to see how that works in your development environment.
It should be as simple as pip install pre-commit followed by pre-commit install in the repository directory.

* black (source code formatting)
* syntax validation
* basic flake8 checks

Add an entry point to enable pre-commits if the package is installed
in a dials environment.
@Anthchirp Anthchirp requested a review from KarlLevik May 3, 2019 14:54
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.183% when pulling b77c8a5 on precommit into d1f48f7 on master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.183% when pulling b77c8a5 on precommit into d1f48f7 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.183% when pulling b77c8a5 on precommit into d1f48f7 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.183% when pulling b77c8a5 on precommit into d1f48f7 on master.

@coveralls
Copy link

coveralls commented May 3, 2019

Coverage Status

Coverage remained the same at 82.183% when pulling 502e34e on precommit into d1f48f7 on master.

Copy link
Member

@KarlLevik KarlLevik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip install pre-commit and pre-commit install seem to do something, and no errors! So I'll assume this works. We should probably have documentation notes somewhere for developers about these steps.

@Anthchirp
Copy link
Contributor Author

Good point. I've added some documentation blurb. If you're happy with this then it can go in.

@KarlLevik
Copy link
Member

Yes, that looks good! Thank you!

@KarlLevik KarlLevik merged commit 8d4d44d into master May 9, 2019
@Anthchirp Anthchirp deleted the precommit branch June 17, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants