Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated method to store program attachments + new method to retrieve expired sessions #87

Merged
merged 4 commits into from Nov 11, 2019
Merged

Updated method to store program attachments + new method to retrieve expired sessions #87

merged 4 commits into from Nov 11, 2019

Conversation

KarlLevik
Copy link
Member

  • Use ispyb-database-1.8.0
  • New method retrieve_expired_sessions_for_instrument_and_period + test
  • Updated SP + param dict for upsert_program_attachment

@coveralls
Copy link

coveralls commented Nov 8, 2019 •
edited

Coverage Status

Coverage increased (+0.08%) to 81.919% when pulling eba3254 on appa_exp_sessions into 3f68543 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 81.84% when pulling bd54ed7 on appa_exp_sessions into 3f68543 on master.

Anthchirp
Anthchirp approved these changes Nov 11, 2019
View reviewed changes
ispyb/sp/mxprocessing.py Outdated Show resolved Hide resolved
@KarlLevik @Anthchirp
Update ispyb/sp/mxprocessing.py
eba3254 
Use lower-case key in dict.

Co-Authored-By: Markus Gerstel <2102431+Anthchirp@users.noreply.github.com>
@KarlLevik KarlLevik merged commit 8fd1795 into master Nov 11, 2019
@Anthchirp Anthchirp deleted the appa_exp_sessions branch January 28, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anthchirp Anthchirp Anthchirp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KarlLevik @coveralls @Anthchirp