Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate API call into its own file and simplify #38

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Separate API call into its own file and simplify #38

merged 5 commits into from
Jul 8, 2024

Conversation

callumforrester
Copy link
Contributor

Refactor:

  • Separate graylog API call into its own file
  • Build query using function rather than hold it as global state
  • Simplify table construction using row-wise encoding rather than column-wise
  • Simplify colour lookup

@callumforrester callumforrester force-pushed the separate-api-call branch 2 times, most recently from 6ffd6ec to 57a89a9 Compare June 18, 2024 15:00
@callumforrester callumforrester marked this pull request as ready for review June 18, 2024 15:04
@callumforrester callumforrester merged commit abf315d into main Jul 8, 2024
5 checks passed
@callumforrester callumforrester deleted the separate-api-call branch July 8, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TBThomas56 TBThomas56 Awaiting requested review from TBThomas56

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@callumforrester