BREAKING CHANGE: supporting only node above 12 (#84)

* BREAKING CHANGE: supporting only node above 10 * dependencies upgrade
DianaSuvorova · Feb 8, 2022 · b1298ac · b1298ac
1 parent 16734b8
commit b1298ac
Show file tree

Hide file tree

Showing 17 changed files with 2,514 additions and 3,653 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -13,7 +13,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [8.x, 10.x, 12.x]
+        node-version: [12.x, 14.x, 16.x]
 
     steps:
     - uses: actions/checkout@v2

diff --git a/.npmrc b/.npmrc
diff --git a/lib/rules/mapStateToProps-no-store.js b/lib/rules/mapStateToProps-no-store.js
@@ -20,7 +20,7 @@ const propertyIsStore = (prop, storeName) => {
     return true;
   } else if (
     // ...state
-    prop.type === 'ExperimentalSpreadProperty'
+    prop.type === 'SpreadElement'
     && prop.argument && prop.argument.type === 'Identifier'
     && prop.argument.name === storeName
   ) {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -9,51 +9,49 @@
     "react-redux"
   ],
   "author": "diana.suvorova@gmail.com",
-  "main": "dist/index.js",
+  "main": "index.js",
   "scripts": {
     "lint": "eslint ./lib ./tests",
-    "test": "npm run lint && mocha --compilers js:babel-register tests --recursive",
+    "test": "npm run lint && mocha tests --recursive",
     "semantic-release": "semantic-release",
-    "commitmsg": "npm run test && commitlint -e $GIT_PARAMS",
-    "build": "rm -fr ./dist && babel ./lib --out-dir ./dist --copy-files",
-    "prepublishOnly": "npm test && npm run build"
+    "commitmsg": "npm run test && commitlint -e $GIT_PARAMS"
   },
   "repository": {
     "type": "git",
     "url": "https://github.com/DianaSuvorova/eslint-plugin-react-redux"
   },
   "devDependencies": {
+    "@babel/core": "^7.17.0",
+    "@babel/eslint-parser": "^7.17.0",
     "@commitlint/cli": "^6.0.2",
     "@commitlint/config-conventional": "^6.0.2",
-    "babel-cli": "^6.26.0",
-    "babel-eslint": "^8.1.0",
     "babel-plugin-transform-object-rest-spread": "^6.26.0",
-    "babel-preset-env": "^1.7.0",
     "babel-register": "^6.26.0",
-    "eslint": "^4.14.0",
+    "eslint": "^8.8.0",
     "eslint-config-airbnb": "^16.1.0",
     "eslint-config-standard": "^11.0.0-beta.0",
-    "eslint-plugin-import": "^2.8.0",
-    "eslint-plugin-jsx-a11y": "^6.0.3",
+    "eslint-plugin-import": "^2.25.4",
+    "eslint-plugin-jsx-a11y": "^6.5.1",
     "eslint-plugin-node": "^5.2.1",
     "eslint-plugin-promise": "^3.6.0",
     "eslint-plugin-standard": "^3.0.1",
-    "husky": "^0.14.3",
-    "mocha": "^4.0.1",
+    "husky": "^7.0.4",
+    "mocha": "^9.2.0",
     "semantic-release": "^17.2.3"
   },
   "peerDependencies": {
-    "eslint-plugin-react": "^7.16.0"
+    "eslint-plugin-react": "^7.28.0",
+    "eslint": "^7 || ^8"
   },
   "engines": {
-    "node": ">=8.0.0"
+    "node": ">=12.0.0"
   },
   "license": "ISC",
   "directories": {
     "test": "tests"
   },
   "dependencies": {
-    "eslint-rule-composer": "^0.3.0",
-    "eslint-plugin-react": "^7.16.0"
+    "eslint-plugin-react": "^7.28.0",
+    "eslint-rule-composer": "^0.3.0"
   }
 }
diff --git a/tests/lib/rules/connect-prefer-minimum-two-arguments.js b/tests/lib/rules/connect-prefer-minimum-two-arguments.js
@@ -1,15 +1,10 @@
-require('babel-eslint');
-
 const rule = require('../../../lib/rules/connect-prefer-minimum-two-arguments');
 const RuleTester = require('eslint').RuleTester;
 const codeSamples = require('../../code-sanity-samples');
 
 const parserOptions = {
-  ecmaVersion: 6,
+  ecmaVersion: 2018,
   sourceType: 'module',
-  ecmaFeatures: {
-    experimentalObjectRestSpread: true,
-  },
 };
 
 const ruleTester = new RuleTester({ parserOptions });

diff --git a/tests/lib/rules/connect-prefer-named-arguments.js b/tests/lib/rules/connect-prefer-named-arguments.js
@@ -1,15 +1,10 @@
-require('babel-eslint');
-
 const rule = require('../../../lib/rules/connect-prefer-named-arguments');
 const RuleTester = require('eslint').RuleTester;
 const codeSamples = require('../../code-sanity-samples');
 
 const parserOptions = {
-  ecmaVersion: 6,
+  ecmaVersion: 2018,
   sourceType: 'module',
-  ecmaFeatures: {
-    experimentalObjectRestSpread: true,
-  },
 };
 
 const ruleTester = new RuleTester({ parserOptions });

diff --git a/tests/lib/rules/mapDispatchToProps-prefer-parameters-names.js b/tests/lib/rules/mapDispatchToProps-prefer-parameters-names.js
@@ -1,15 +1,10 @@
-require('babel-eslint');
-
 const rule = require('../../../lib/rules/mapDispatchToProps-prefer-parameters-names');
 const RuleTester = require('eslint').RuleTester;
 const codeSamples = require('../../code-sanity-samples');
 
 const parserOptions = {
-  ecmaVersion: 6,
+  ecmaVersion: 2018,
   sourceType: 'module',
-  ecmaFeatures: {
-    experimentalObjectRestSpread: true,
-  },
 };
 
 const ruleTester = new RuleTester({ parserOptions });

diff --git a/tests/lib/rules/mapDispatchToProps-prefer-shorthand.js b/tests/lib/rules/mapDispatchToProps-prefer-shorthand.js
@@ -1,16 +1,11 @@
-require('babel-eslint');
-
 const rule = require('../../../lib/rules/mapDispatchToProps-prefer-shorthand');
 const RuleTester = require('eslint').RuleTester;
 const codeSamples = require('../../code-sanity-samples');
 
 
 const parserOptions = {
-  ecmaVersion: 6,
+  ecmaVersion: 2018,
   sourceType: 'module',
-  ecmaFeatures: {
-    experimentalObjectRestSpread: true,
-  },
 };
 
 const ruleTester = new RuleTester({ parserOptions });

diff --git a/tests/lib/rules/mapDispatchToProps-returns-object.js b/tests/lib/rules/mapDispatchToProps-returns-object.js
@@ -1,15 +1,10 @@
-require('babel-eslint');
-
 const rule = require('../../../lib/rules/mapDispatchToProps-returns-object');
 const RuleTester = require('eslint').RuleTester;
 const codeSamples = require('../../code-sanity-samples');
 
 const parserOptions = {
-  ecmaVersion: 6,
+  ecmaVersion: 2018,
   sourceType: 'module',
-  ecmaFeatures: {
-    experimentalObjectRestSpread: true,
-  },
 };
 
 const ruleTester = new RuleTester({ parserOptions });

diff --git a/tests/lib/rules/mapStateToProps-no-store.js b/tests/lib/rules/mapStateToProps-no-store.js
@@ -1,14 +1,13 @@
-require('babel-eslint');
 
 const rule = require('../../../lib/rules/mapStateToProps-no-store');
 const RuleTester = require('eslint').RuleTester;
 const codeSamples = require('../../code-sanity-samples');
 
 const parserOptions = {
-  ecmaVersion: 6,
+  ecmaVersion: 2018,
   sourceType: 'module',
   ecmaFeatures: {
-    experimentalObjectRestSpread: true,
+    jsx: true,
   },
 };
 

diff --git a/tests/lib/rules/mapStateToProps-prefer-hoisted.js b/tests/lib/rules/mapStateToProps-prefer-hoisted.js
@@ -1,15 +1,11 @@
-require('babel-eslint');
 
 const rule = require('../../../lib/rules/mapStateToProps-prefer-hoisted');
 const RuleTester = require('eslint').RuleTester;
 const codeSamples = require('../../code-sanity-samples');
 
 const parserOptions = {
-  ecmaVersion: 6,
+  ecmaVersion: 2018,
   sourceType: 'module',
-  ecmaFeatures: {
-    experimentalObjectRestSpread: true,
-  },
 };
 
 const errorMessage = 'constant arrays and objects should be initialized outside of mapStateToProps';

diff --git a/tests/lib/rules/mapStateToProps-prefer-parameters-names.js b/tests/lib/rules/mapStateToProps-prefer-parameters-names.js
@@ -1,15 +1,10 @@
-require('babel-eslint');
-
 const rule = require('../../../lib/rules/mapStateToProps-prefer-parameters-names');
 const RuleTester = require('eslint').RuleTester;
 const codeSamples = require('../../code-sanity-samples');
 
 const parserOptions = {
-  ecmaVersion: 6,
+  ecmaVersion: 2018,
   sourceType: 'module',
-  ecmaFeatures: {
-    experimentalObjectRestSpread: true,
-  },
 };
 
 const ruleTester = new RuleTester({ parserOptions });

diff --git a/tests/lib/rules/mapStateToProps-prefer-selectors.js b/tests/lib/rules/mapStateToProps-prefer-selectors.js
@@ -1,15 +1,10 @@
-require('babel-eslint');
-
 const rule = require('../../../lib/rules/mapStateToProps-prefer-selectors');
 const RuleTester = require('eslint').RuleTester;
 const codeSamples = require('../../code-sanity-samples');
 
 const parserOptions = {
-  ecmaVersion: 6,
+  ecmaVersion: 2018,
   sourceType: 'module',
-  ecmaFeatures: {
-    experimentalObjectRestSpread: true,
-  },
 };
 
 const ruleTester = new RuleTester({ parserOptions });

diff --git a/tests/lib/rules/no-unused-prop-types.js b/tests/lib/rules/no-unused-prop-types.js
@@ -1,14 +1,12 @@
-require('babel-eslint');
 
 const rule = require('../../../lib/rules/no-unused-prop-types');
 const RuleTester = require('eslint').RuleTester;
 const codeSamples = require('../../code-sanity-samples');
 
 const parserOptions = {
-  ecmaVersion: 6,
+  ecmaVersion: 2018,
   sourceType: 'module',
   ecmaFeatures: {
-    experimentalObjectRestSpread: true,
     jsx: true,
   },
 };

diff --git a/tests/lib/rules/prefer-separate-component-file.js b/tests/lib/rules/prefer-separate-component-file.js
@@ -1,15 +1,10 @@
-require('babel-eslint');
-
 const rule = require('../../../lib/rules/prefer-separate-component-file');
 const RuleTester = require('eslint').RuleTester;
 const codeSamples = require('../../code-sanity-samples');
 
 const parserOptions = {
-  ecmaVersion: 6,
+  ecmaVersion: 2018,
   sourceType: 'module',
-  ecmaFeatures: {
-    experimentalObjectRestSpread: true,
-  },
 };
 
 const ruleTester = new RuleTester({ parserOptions });

diff --git a/tests/lib/rules/useSelector-prefer-selectors.js b/tests/lib/rules/useSelector-prefer-selectors.js
@@ -1,15 +1,10 @@
-require('babel-eslint');
-
 const rule = require('../../../lib/rules/useSelector-prefer-selectors');
 const RuleTester = require('eslint').RuleTester;
 const codeSamples = require('../../code-sanity-samples');
 
 const parserOptions = {
-  ecmaVersion: 6,
+  ecmaVersion: 2018,
   sourceType: 'module',
-  ecmaFeatures: {
-    experimentalObjectRestSpread: true,
-  },
 };
 
 const ruleTester = new RuleTester({ parserOptions });