BREAKING CHANGE: supporting only node above 12 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Feb 7, 2022
package.json
Outdated
| @@ -30,23 +28,24 @@ | |||
| "babel-plugin-transform-object-rest-spread": "^6.26.0", | |||
| "babel-preset-env": "^1.7.0", | |||
| "babel-register": "^6.26.0", | |||
| "eslint": "^4.14.0", | |||
| "eslint": "^4.19.1", | |||
There was a problem hiding this comment.
and I would 100% agree with you. Let me dot it
.github/workflows/tests.yml
Outdated
| @@ -13,7 +13,7 @@ jobs: | |||
|
|
|||
| strategy: | |||
| matrix: | |||
| node-version: [8.x, 10.x, 12.x] | |||
| node-version: [10.x, 12.x] | |||
There was a problem hiding this comment.
Suggested change
| node-version: [10.x, 12.x] | |
| node-version: [10.x, 12.x, 14.x, 16.x] |
ljharb
reviewed
Feb 7, 2022
package.json
Outdated
| "semantic-release": "^17.2.3" | ||
| }, | ||
| "peerDependencies": { | ||
| "eslint-plugin-react": "^7.16.0" | ||
| "eslint-plugin-react": "^7.16.0", |
There was a problem hiding this comment.
might as well hoist this up to the latest version of eslint-plugin-react also, since you're doing a breaking change anyways
There was a problem hiding this comment.
you don't have days off do you 😆
There was a problem hiding this comment.
every hour's an hour off from lots of things :-p there's just more than 24 hours worth of things to do in a day
ljharb
reviewed
Feb 7, 2022
|
@ljharb I think this should do it. lmk if you see anything off. Thank you 🙏 |
DianaSuvorova
changed the title
ljharb
approved these changes
Feb 8, 2022
| @@ -13,7 +13,7 @@ jobs: | |||
|
|
|||
| strategy: | |||
| matrix: | |||
| node-version: [8.x, 10.x, 12.x] | |||
| node-version: [12.x, 14.x, 16.x] | |||
There was a problem hiding this comment.
Suggested change
| node-version: [12.x, 14.x, 16.x] | |
| node-version: [12.x, 14.x, 16.x, 17.x] |
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is time to move on... Node8 is not supported starting eslint@7
closes #83