Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.6-3.9, drop EOL 2.6 and 3.2-3.4 #29

Merged
merged 6 commits into from
Jul 14, 2020

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jan 20, 2020

Fixes #28.

This PR:

Declares support for and tests new Python 3.6-3.8.

It tests on Python 3.9-dev, due out in October, but already in alpha. It fixes a removed deprecation to use collections.abc where available.

This also drops support for EOL Python 2.6, 3.2-3.4.

  • Python 2.6, 3.2 and 3.3 have been dropped by Travis CI so are not easily testable.

Add python_requires metadata to help pip install for people on older Python versions.

I haven't removed EOL 2.7 yet, but would recommend doing so as well. Please let me know if you'd like that removing too, but I mainly recommend getting the 3.9 fix in as soon as possible.

Thank you!

@hugovk
Copy link
Contributor Author

hugovk commented Jan 20, 2020

Passing CI build:

Here's a build before the 3.9 fix, showing the problem:

Copy link
Owner

@Diaoul Diaoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, missed that one. Thanks for your contribution!
LGTM

@Diaoul Diaoul merged commit 0ac7b19 into Diaoul:master Jul 14, 2020
@hugovk hugovk deleted the fix-py39 branch July 15, 2020 05:41
@labrys labrys mentioned this pull request Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants