-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooling update #34
Tooling update #34
Conversation
25f019f
to
b261852
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is great. I'm glad to see someone else taking the jump into poetry lol.
|
||
set -ex | ||
|
||
pytest --verbose --cov=babelfish --cov-report=term-missing --cov-report=xml tests/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would better be done with poethepoet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting project ! I am not sure at this stage I want another tool to centralize so little. Also seems a bit young.
Definitely something to keep in mind if I add more stuff though.
@@ -1,4 +1,7 @@ | |||
[tox] | |||
envlist = py27,py35,py36,py37,py38,py39,pypy | |||
envlist = py36,py37,py38,py39,pypy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would better be done using a GitHub actions matrix for multiple os/py version combinations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a GitHub Actions matrix, this was more for local testing. Tbh, I am lazy and rely on the CI 99% of the time 😆
I can get rid of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, I usually just push and pray ci passes. But even then there is netkos/act to run actions locally
I've "merged" this by making the main branch the new default branch. |
This PR aims to make babelfish's tooling up-to-date.