Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling update #34

Closed
wants to merge 17 commits into from
Closed

Tooling update #34

wants to merge 17 commits into from

Conversation

Diaoul
Copy link
Owner

@Diaoul Diaoul commented Jul 13, 2021

This PR aims to make babelfish's tooling up-to-date.

  • Use poetry
  • Use pytest
  • Move documentation to README
  • Python 3.6+ only
  • Use GitHub Actions as CI
  • CI badge in README
  • Publish to PyPI on GitHub Release

@Diaoul Diaoul marked this pull request as draft July 13, 2021 19:00
@Diaoul Diaoul force-pushed the main branch 2 times, most recently from 25f019f to b261852 Compare July 13, 2021 21:19
@Diaoul Diaoul marked this pull request as ready for review July 13, 2021 21:43
@Diaoul
Copy link
Owner Author

Diaoul commented Jul 13, 2021

/cc @labrys @Safihre @miigotu
This should address your immediate issues, can you please take a look?

Copy link

@miigotu miigotu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is great. I'm glad to see someone else taking the jump into poetry lol.


set -ex

pytest --verbose --cov=babelfish --cov-report=term-missing --cov-report=xml tests/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would better be done with poethepoet

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting project ! I am not sure at this stage I want another tool to centralize so little. Also seems a bit young.
Definitely something to keep in mind if I add more stuff though.

@@ -1,4 +1,7 @@
[tox]
envlist = py27,py35,py36,py37,py38,py39,pypy
envlist = py36,py37,py38,py39,pypy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would better be done using a GitHub actions matrix for multiple os/py version combinations.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a GitHub Actions matrix, this was more for local testing. Tbh, I am lazy and rely on the CI 99% of the time 😆
I can get rid of it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, I usually just push and pray ci passes. But even then there is netkos/act to run actions locally

@Diaoul
Copy link
Owner Author

Diaoul commented Jul 14, 2021

I've "merged" this by making the main branch the new default branch.

@Diaoul Diaoul closed this Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants