Changed all log messages to proper formatting. #562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix is wrong, the formatting should be done by the logger functions for performance optimization. I don't now why you have this error, maybe changing %r to %s will solve the issue? Can you try that? |
|
Still an issue.. even after changing to %s: |
|
Since most of the time is spent on HTTP access to the subtitle sites, is it really necessary to optimize log messages? |
|
It's the way it is supposed to work see the official doccumentation. I'll try to reproduce your issue but I think there is something wrong with your setup. |
|
I'm closing since this is a local issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log messages would cause errors in Python 3.5 because of bad formatting, so I've fixed all the log message lines.
Error screenshot: