Added Argenteam Provider #705

juanmhidalgo · 2016-10-15T06:08:15Z

Added Argenteam Provider (#595).

coveralls · 2016-10-15T06:40:09Z

Coverage increased (+0.08%) to 91.904% when pulling b8dde09 on juanmhidalgo:argenteam into dd74383 on Diaoul:master.

coveralls · 2016-10-15T06:40:09Z

Coverage increased (+0.08%) to 91.904% when pulling b8dde09 on juanmhidalgo:argenteam into dd74383 on Diaoul:master.

coveralls · 2016-10-15T06:40:09Z

Coverage increased (+0.08%) to 91.904% when pulling b8dde09 on juanmhidalgo:argenteam into dd74383 on Diaoul:master.

Diaoul

Thanks for the PR, I requested some changes (see review comments).
Please use 120 characters line wrapping and ensure the docstrings are consistent. Make sure logging is accurate and takes place in the right spot.

Diaoul · 2016-10-15T19:15:11Z

setup.py

@@ -75,7 +75,8 @@ def find_version(*file_paths):
              'shooter = subliminal.providers.shooter:ShooterProvider',
              'subscenter = subliminal.providers.subscenter:SubsCenterProvider',
              'thesubdb = subliminal.providers.thesubdb:TheSubDBProvider',
-              'tvsubtitles = subliminal.providers.tvsubtitles:TVsubtitlesProvider'
+              'tvsubtitles = subliminal.providers.tvsubtitles:TVsubtitlesProvider',
+              'argenteam = subliminal.providers.argenteam:ArgenteamProvider'


Please keep it alphabetically ordered

Diaoul · 2016-10-15T19:16:32Z

subliminal/providers/argenteam.py

+        self.episode = episode
+        self.release = release
+        self.version = version
+        logger.info('Release %r Version %r', release, version)


Remove this log.

Diaoul · 2016-10-15T19:16:35Z

subliminal/providers/argenteam.py

+        return self.download_link
+
+    def get_matches(self, video):
+        logger.info('GetMatches')


Remove this log.

Diaoul · 2016-10-18T08:42:48Z

subliminal/providers/argenteam.py

+    def terminate(self):
+        self.session.close()
+
+    def search_show_id(self, series, year=None):


If the year parameter isn't used, remove it and update the docs.

Diaoul · 2016-10-18T08:43:05Z

subliminal/providers/argenteam.py

+        :param year: year of the series, if any.
+        :type year: int or None
+        :return: the show id, if any.
+        :rtype: int or None


The docstring doesn't match the function

Docstring not accurate.

Diaoul · 2016-10-18T13:18:24Z

subliminal/providers/argenteam.py

+
+        episode_id = self.search_episode_id(series, season, episode)
+        if episode_id is None:
+            logger.error('No show id found for %r', series)


Rather than here

Diaoul · 2016-10-18T13:19:16Z

tests/test_extensions.py

-    assert len(extensions) == 9
-    assert extensions == ['addic7ed', 'de7cidda', 'legendastv', 'opensubtitles', 'podnapisi', 'shooter', 'subscenter',
+    assert len(extensions) == 10
+    assert extensions == ['addic7ed', 'argenteam', 'de7cidda', 'legendastv',


Put argenteam after de7cidda

Diaoul · 2016-10-18T13:19:34Z

subliminal/providers/argenteam.py

+            for s in r['subtitles']:
+                sub = ArgenteamSubtitle(
+                    language, s['uri'], series,
+                    season, episode, r['team'], r['tags'])


Use 120 characters line wrapping

Diaoul · 2016-10-18T13:19:37Z

subliminal/providers/argenteam.py

+            return []
+
+        r = self.session.get(self.API_URL + 'episode',
+                             params={'id': episode_id}, timeout=10)


Use 120 characters line wrapping

Diaoul · 2016-10-18T13:19:45Z

subliminal/providers/argenteam.py

+        query = '%s S%#02dE%#02d' % (series, season, episode)
+        logger.info('Searching show id for %r', query)
+        r = self.session.get(self.API_URL + 'search',
+                             params={'q': query}, timeout=10)


Use 120 characters line wrapping

juanmhidalgo · 2016-10-22T16:44:03Z

@Diaoul Thanks for your feedback.
I pushed some commits with fixes.

Diaoul

Please fix the above and squash commits. If there is any further changes I will make them after merging.

Diaoul · 2016-10-23T11:19:09Z

subliminal/providers/argenteam.py

        r.raise_for_status()
        results = json.loads(r.text)
        episode_id = None
        if results['total'] == 1:
            episode_id = results['results'][0]['id']
+        else:
+            logger.error('No show id found for %r', series)


I think you mean episode_id here.
Also the docstring of that function is not accurate.

Diaoul · 2016-10-23T11:20:24Z

setup.py

@@ -69,13 +69,14 @@ def find_version(*file_paths):
      entry_points={
          'subliminal.providers': [
              'addic7ed = subliminal.providers.addic7ed:Addic7edProvider',
+              'argenteam = subliminal.providers.argenteam:ArgenteamProvider'


There is a coma missing at the end.

Diaoul · 2016-10-23T11:20:45Z

subliminal/providers/argenteam.py

+    provider_name = 'argenteam'
+
+    def __init__(self, language, download_link,
+                 series, season, episode, release, version, *args, **kwargs):


Line wrap to 120.

Diaoul · 2016-10-23T11:21:04Z

subliminal/providers/argenteam.py

+        # format
+        if video.format and self.version and video.format.lower() in self.version.lower():
+            matches.add('format')
+        matches |= guess_matches(


Line wrap to 120.

@juanmhidalgo you missed this one. Put everything in one line

Diaoul · 2016-10-23T11:21:14Z

subliminal/providers/argenteam.py

+
+    def initialize(self):
+        self.session = Session()
+        self.session.headers = {


Line wrap to 120.

Diaoul · 2016-10-23T11:21:29Z

subliminal/providers/argenteam.py

+        """
+        # make the search
+        logger.info('Searching show id for %r', series)
+        r = self.session.get(self.API_URL + 'search',


Line wrap to 120.

Diaoul · 2016-10-23T11:22:17Z

subliminal/providers/argenteam.py

+        :param year: year of the series, if any.
+        :type year: int or None
+        :return: the show id, if any.
+        :rtype: int or None


Docstring not accurate.

Diaoul · 2016-10-23T11:22:47Z

subliminal/providers/argenteam.py

+        if results['total'] == 1:
+            episode_id = results['results'][0]['id']
+        else:
+            logger.error('No show id found for %r', series)


You mean episode_id here I believe.

Diaoul · 2016-10-23T11:23:00Z

subliminal/providers/argenteam.py

+        if episode_id is None:
+            return []
+
+        r = self.session.get(self.API_URL + 'episode',


Line wrap to 120.

protron · 2016-12-03T05:28:17Z

@juanmhidalgo It's a shame this provider being so close to been merged, and now it's broken. I could try fixing it, but I guess I would have to create a new PR. Based on your branch of course. But maybe it still feels like stealing your work (your commits will still be there). Please let us know if you already give up on this.

coveralls · 2017-01-08T12:42:58Z

Coverage increased (+0.08%) to 91.904% when pulling 9745790 on juanmhidalgo:argenteam into dd74383 on Diaoul:master.

coveralls · 2017-01-08T12:42:58Z

Coverage increased (+0.08%) to 91.904% when pulling 9745790 on juanmhidalgo:argenteam into dd74383 on Diaoul:master.

juanmhidalgo · 2017-01-09T12:09:25Z

Hi @protron I updated the PR. Let me know if it is ok or not.

fernandog · 2017-06-29T12:33:04Z

@juanmhidalgo you missed one request change: #705 (comment)
Put everything in one line

ratoaq2 · 2019-02-17T17:31:50Z

This PR is against master. It should be against develop branch

ratoaq2 · 2019-02-23T17:11:19Z

Fixed by 41f5c15
Thanks

juanmhidalgo changed the title ~~Argenteam Provider~~ Added Argenteam Provider Oct 15, 2016

Diaoul requested changes Oct 18, 2016

View reviewed changes

Diaoul requested changes Oct 23, 2016

View reviewed changes

juanmhidalgo force-pushed the argenteam branch from b3d56d5 to 8e1b661 Compare January 3, 2017 05:05

Add argenteam provider (episodes only)

fa84ff4

juanmhidalgo force-pushed the argenteam branch from 8e1b661 to fa84ff4 Compare January 3, 2017 05:09

Modified extensions order be alphabetical

9745790

fernandog added the type/new-provider label Nov 18, 2017

ratoaq2 added the status/on-hold label Feb 17, 2019

ratoaq2 closed this Feb 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Argenteam Provider #705

Added Argenteam Provider #705

juanmhidalgo commented Oct 15, 2016

coveralls commented Oct 15, 2016 •

edited

coveralls commented Oct 15, 2016

coveralls commented Oct 15, 2016

Diaoul left a comment

Diaoul Oct 15, 2016

Diaoul Oct 15, 2016

Diaoul Oct 15, 2016

Diaoul Oct 18, 2016

Diaoul Oct 18, 2016

Diaoul Oct 23, 2016

Diaoul Oct 18, 2016

Diaoul Oct 18, 2016

Diaoul Oct 18, 2016

Diaoul Oct 18, 2016

Diaoul Oct 18, 2016

juanmhidalgo commented Oct 22, 2016

Diaoul left a comment

Diaoul Oct 23, 2016

Diaoul Oct 23, 2016

Diaoul Oct 23, 2016

Diaoul Oct 23, 2016

fernandog Jun 19, 2017

Diaoul Oct 23, 2016

Diaoul Oct 23, 2016

Diaoul Oct 23, 2016

Diaoul Oct 23, 2016

Diaoul Oct 23, 2016

protron commented Dec 3, 2016

coveralls commented Jan 8, 2017 •

edited

coveralls commented Jan 8, 2017

juanmhidalgo commented Jan 9, 2017

fernandog commented Jun 29, 2017

ratoaq2 commented Feb 17, 2019

ratoaq2 commented Feb 23, 2019

Added Argenteam Provider #705

Added Argenteam Provider #705

Conversation

juanmhidalgo commented Oct 15, 2016

coveralls commented Oct 15, 2016 • edited

coveralls commented Oct 15, 2016

coveralls commented Oct 15, 2016

Diaoul left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juanmhidalgo commented Oct 22, 2016

Diaoul left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

protron commented Dec 3, 2016

coveralls commented Jan 8, 2017 • edited

coveralls commented Jan 8, 2017

juanmhidalgo commented Jan 9, 2017

fernandog commented Jun 29, 2017

ratoaq2 commented Feb 17, 2019

ratoaq2 commented Feb 23, 2019

coveralls commented Oct 15, 2016 •

edited

coveralls commented Jan 8, 2017 •

edited