Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aRGENTeaM provider #883

Closed
wants to merge 5 commits into from

Conversation

mmiraglia
Copy link
Contributor

aRGENTeaM is a great spanish subtitle provider, especially for the latin community. Only episodes subtitles are supported in this first release of the provider.

@mmiraglia mmiraglia changed the base branch from master to develop February 1, 2018 15:07
@mmiraglia
Copy link
Contributor Author

I fixed some errors from the previus PR. I hope this time everything is OK.

@fernandog
Copy link
Collaborator

fernandog commented Feb 1, 2018

@mmiraglia you missed this implementation: #778

Also Diaoul has the final word about providers. I can't do much about this

@mmiraglia
Copy link
Contributor Author

@fernandog I relied on the develop branch ... I do not understand how I missed it :(
Anyway, can you help me to incorporate the implementation to this branch? Even with a googled link :)

@mmiraglia
Copy link
Contributor Author

@fernandog my bad! Finally I understood your requirement. Please, check it and give me your feedback.

@fernandog
Copy link
Collaborator

@mmiraglia remove the commented code

@fernandog
Copy link
Collaborator

@mmiraglia you also missed the cassettes. When you run the test it creates a cassette. Check the test foldee

@mmiraglia
Copy link
Contributor Author

I'm sorry @fernandog . As I mentioned earlier, I am new developing python and github.

@ratoaq2
Copy link
Collaborator

ratoaq2 commented Feb 23, 2019

I squashed your commits and fixed remaining issues to have a functional provider

Fixed by 41f5c15
Thanks

@ratoaq2 ratoaq2 closed this Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants