Switch Podnapisi.NET to json API. #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratoaq2
force-pushed
the
feature/podnapisi-json
branch
2 times, most recently
from
1940c2d
to
b72afc9
Compare
MasterMind2k
approved these changes
Mar 27, 2019
subliminal/providers/podnapisi.py
Outdated
| page_link = data['url'] | ||
| releases = data['releases'] + data['custom_releases'] | ||
| title = data['movie']['title'] | ||
| season = int(data['movie']['episode_info']['season']) if is_episode else None |
There was a problem hiding this comment.
Season and episode may not be defined. I believe using a get with apropriate default value would be a better choice.
… properly search tv-series even if season is 0
ratoaq2
force-pushed
the
feature/podnapisi-json
branch
from
b72afc9
to
faffd7a
Compare
This was referenced May 9, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice if some users could try it
@MasterMind2k @hachel