Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft messages are lost if orientation changes #64

Closed
pravi opened this issue Sep 3, 2016 · 10 comments
Closed

draft messages are lost if orientation changes #64

pravi opened this issue Sep 3, 2016 · 10 comments
Assignees
Labels
Milestone

Comments

@pravi
Copy link

pravi commented Sep 3, 2016

When posting a new mesage in portrait, if orientation changes, message being typed is lost and stream is shown. Its very irritating to type again.

Even regular stream gets reloaded when orientation changes.

General information

  • Device: Yu Yuphoroa
  • Android Version: Cyanogen Mod 12.1
  • Pod: poddery.com
  • Diaspora pod version: 0.6.0.0
  • App source: F-Droid
  • App version: 0.1.5

Steps to reproduce

  1. …create a new post
  2. …type something
  3. …change orientation

Expected result

What is the expected output?

You should not lose the message you typed.

Stream is loaded instead.

@vanitasvitae
Copy link
Collaborator

Can't reproduce that one. Make sure you do NOT have something like "Don't keep activities" checked in the developer options.

@pravi
Copy link
Author

pravi commented Sep 3, 2016

@vanitasvitae I don't have that option checked, though I could not reproduce it on HTC Desire 816G with Android 4.4.2. What version of Android do you have?

@vanitasvitae
Copy link
Collaborator

@pravi: I'm running a Nexus 5 with CopperheadOS (Android 6). Thr issue could be caused by limited RAM I guess?

Am 3. September 2016 10:12:02 MESZ, schrieb Praveen Arimbrathodiyil notifications@github.com:

@vanitasvitae I don't have that option checked, though I could not
reproduce it on HTC Desire 816G with Android 4.4.2. What version of
Android do you have?

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#64 (comment)

Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

@pravi
Copy link
Author

pravi commented Sep 3, 2016

@vanitasvitae browser does orientation switching without any issues, so I doubt it is RAM. It has 2GB RAM.

@gsantner
Copy link
Owner

gsantner commented Sep 3, 2016

Good if it does, but it shouln't save the content. Usually an orientation change let your android re-render the layout. (onCreate called ;). Btw: Text also stays on my device.

Bundle savedInstanceState may be a good hint, if someone goes onto this.

@vanitasvitae
Copy link
Collaborator

But isn't the content saved in onPause or onSaveWebViewState or something like that?

Am 3. September 2016 12:15:42 MESZ, schrieb Gregor Santner notifications@github.com:

Good if it does, but it shouln't save the content. Usually an
orientation chagne lets your android re-render the layout. (onCreate
called ;).

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#64 (comment)

Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

@vanitasvitae
Copy link
Collaborator

@pravi Could you try this experimental apk? I made some experimental changes and the apk is signed with my key, so you have to reinstall the app. Also the download might be a little slow. I hope this might change your problem and also make the app a little faster ;)

@vanitasvitae vanitasvitae added this to the v0.1.6 milestone Sep 5, 2016
@vanitasvitae vanitasvitae self-assigned this Sep 5, 2016
@vanitasvitae
Copy link
Collaborator

I merged the changes that I made in the experimental branch into the master branch. Please reopen, if the problem still occurs.

@gsantner
Copy link
Owner

@gsantner gsantner reopened this Sep 11, 2016
@vanitasvitae
Copy link
Collaborator

This is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants