Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set and Get tests #110

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Set and Get tests #110

wants to merge 3 commits into from

Conversation

ayo-ajayi
Copy link

Wrote a test file to address the issues listed in issue #69 and #71

  1. covers the correctness of single command
  2. covers the correctness when multiple commands are fired
  3. no commands are dropped abruptly
  4. ensure we check for small, large, and massive inputs

@arpitbbhayani
Copy link
Contributor

@JyotinderSingh what do you think about this?

@JyotinderSingh
Copy link
Contributor

@JyotinderSingh what do you think about this?

LGTM.

nit: I prefer to use the assert library for checks for consistency, but the PR is quite old so we can do that separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants