add new command: FILTERVALS

[manosriram]

No description provided.

[rohanverma94]

Isn't this a heavy library for a basic usecase? A lightweight implementation of the same is possible via reflect and regexp. Note: reflect would be needed to deduce the type " INT, FLOAT, DOUBLE, BOOLEAN, STRING", so regex could match the values better. This however could be a non-issue for the time-being.

[rohanverma94]

Also can't we convert the [][2]string to the string here itself? To encode for a very specific type with a specialized encoder implementation seems tedious for any new command in the future.
It would be easy to process the matched values cumulatively and return string here itself.

0) 0) user:1
    1) value:1
1) 0) user:2
    1) value:2

[manosriram]

by string, you mean []string? because we'll have a list of matches right?

[arpitbbhayani]

@manosriram the return value should be an array to two-tuple allowing we to pipe it with different commands (in the future)

[manosriram]

@arpitbbhayani @rohanverma94 noted, updated in 2fcf3d1

[rohanverma94]

@manosriram Since the requirement is to return an array of two-tuple so that it can be piped to another set of commands. So something on these lines maybe-

type filtervalTuple struct {
    Rkey string; 
    Rvalue interface{}
}

func FilterVals(pattern string) []filtervalTuple {
    rdevice := regexp.MustCompile(pattern)
    var result []filtervalTuple

    for key, value := range store {
        val := value.(string)
        ok := rdevice.MatchString(val)

        if ok {
            result = append(result, filtervalTuple{Rkey:key, Rvalue:val})
        }
    }

    return result
}

Check a sample code here! - https://rohanverma.godbolt.org/z/oeY4rab4s

@arpitbbhayani any further input if you can give then it would be helpful for @manosriram

[manosriram]

@rohanverma94 not sure if the regex will match wildcards, updated other parts except that.

[rohanverma94]

@manosriram It's just a sample code for simplifying the concept 😃

[manosriram]

@rohanverma94 okay 😅

[arpitbbhayani]

Can we not use inherent encoding that we are maintaining instead of reflect?

[arpitbbhayani]

@manosriram this would not work. Use type encodings to check. Not this. Each Dice object holds the type and encoding information. .(string) is an expensive operation. we maintain type encoding information.

[rohanverma94]

@manosriram Ask arpit for review. He knows the requirements well.

[arpitbbhayani]

@manosriram this would not work. Use type encodings to check. Not this. Each Dice object holds the type and encoding information. .(string) is an expensive operation. we maintain type encoding information.

[arpitbbhayani]

we are only doing wildcard match. this is an expensive operation again. please write a simple wildcard matcher and then we will extend the solution if needed.

[arpitbbhayani]

instead of creating a filterVal type, create a generic KV tuple type because we will need it for other commands as well.

[rohanverma94]

@arpitbbhayani The project is based on Go 1.17, and we don't have generic types in that yet. We can still enable this via https://twitter.com/go_perf/status/1427540843175555086?s=20&t=3vX8nwQV5E4aye66nh2G0w . This is nonperformant.

Or you can bump the project version to Go 1.18.

[yashs360]

@manosriram Thanks for the contribution. There are conflicts atm.
The code base has moved forward lot. Please rebase and re-submit if you are still keen to fix this. We will be cleaning up old PR's if they are inactive.