saving integer as integer, keeping all other formats as string #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #3 |
arpitbbhayani
requested changes
Oct 30, 2022
Comment on lines
+70
to
+77
| valueInt, valueIntOrErr := strconv.ParseInt(value, 10, 64) | ||
|
|
||
| // putting the k and value in a Hash Table | ||
| Put(key, NewObj(value, exDurationMs, oType, oEnc)) | ||
| if valueIntOrErr == nil { | ||
| Put(key, NewObj(valueInt, exDurationMs, oType, oEnc)) | ||
| } else { | ||
| Put(key, NewObj(value, exDurationMs, oType, oEnc)) | ||
| } |
There was a problem hiding this comment.
Can we not check this while we are deducing the type and encoding? Doing strconv again is inefficient.
There was a problem hiding this comment.
Would have to make the deduce encoding method more specific for int64 usecases. It will have to return 4 params then instead of the existing two. One with the integer value and the other the err value of parseInt. And this will start bloating when more data types are added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.