Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes aof file permission with arbitrary user #91

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rohanverma94
Copy link
Contributor

Due to misconfigured file permissions for the AOF file, the command BGREWRITEAOF only works once and successive BGREWRITEAOF fails with an error message on the server console. This commit fixes it and uses the correct & appropriate operation mode flags for underlying system calls.

Fixes #90

Due to misconfigured file permissions for the AOF file, the command BGREWRITEAOF only works once and successive BGREWRITEAOF fails with an error message on the server console. This commit fixes it and uses appropriate operation mode flags for underlying system calls.
@rohanverma94 rohanverma94 force-pushed the fix-aof-file-permission-issue branch 2 times, most recently from 7f6ca98 to 4a71ed8 Compare November 9, 2022 17:46
@yashs360
Copy link
Contributor

@rohanverma94 This change is conflicting atm.
The code base has moved forward lot. Please rebase and re-submit if you are still keen to fix this. We will be cleaning up old PR's if they are inactive. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DiceDB doesn't create AOF file with required permission
2 participants