Skip to content

Commit

Permalink
Switch incorrectly configured native multidex to legacy
Browse files Browse the repository at this point in the history
Native multidex can only be used for binaries with minSdkVersion of 21 or higher, but minSdkVersion was specified to 16.

PiperOrigin-RevId: 470003836
  • Loading branch information
rohitjoins authored and marcbaechinger committed Oct 19, 2022
1 parent f454c9a commit 142d1c0
Show file tree
Hide file tree
Showing 9 changed files with 22 additions and 0 deletions.
2 changes: 2 additions & 0 deletions extensions/cronet/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
<uses-sdk/>

<!-- TODO(b/243799715): Use android:name="androidx.multidex.MultiDexApplication" instead. -->
<application
android:name="android.support.multidex.MultiDexApplication"
android:allowBackup="false"
android:usesCleartextTraffic="true"
tools:ignore="MissingApplicationIcon,HardcodedDebugMode"/>
Expand Down
2 changes: 2 additions & 0 deletions extensions/flac/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
<uses-sdk/>

<!-- TODO(b/243799715): Use android:name="androidx.multidex.MultiDexApplication" instead. -->
<application
android:name="android.support.multidex.MultiDexApplication"
android:allowBackup="false"
tools:ignore="MissingApplicationIcon,HardcodedDebugMode"/>

Expand Down
2 changes: 2 additions & 0 deletions extensions/ima/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@
<uses-permission android:name="android.permission.WAKE_LOCK"/>
<uses-sdk/>

<!-- TODO(b/243799715): Use android:name="androidx.multidex.MultiDexApplication" instead. -->
<application
android:name="android.support.multidex.MultiDexApplication"
android:allowBackup="false"
tools:ignore="MissingApplicationIcon,HardcodedDebugMode">
<activity android:name="com.google.android.exoplayer2.testutil.HostActivity"
Expand Down
6 changes: 6 additions & 0 deletions extensions/media2/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
<uses-sdk/>

<!-- TODO(b/243799715): Use android:name="androidx.multidex.MultiDexApplication" instead. -->
<application
android:name="android.support.multidex.MultiDexApplication"
android:allowBackup="false"
tools:ignore="MissingApplicationIcon,HardcodedDebugMode"/>

<instrumentation
android:targetPackage="com.google.android.exoplayer2.ext.media2.test"
android:name="androidx.test.runner.AndroidJUnitRunner"/>
Expand Down
2 changes: 2 additions & 0 deletions extensions/opus/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
<uses-sdk/>

<!-- TODO(b/243799715): Use android:name="androidx.multidex.MultiDexApplication" instead. -->
<application
android:name="android.support.multidex.MultiDexApplication"
android:allowBackup="false"
tools:ignore="MissingApplicationIcon,HardcodedDebugMode"/>

Expand Down
2 changes: 2 additions & 0 deletions extensions/vp9/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
<uses-sdk/>

<!-- TODO(b/243799715): Use android:name="androidx.multidex.MultiDexApplication" instead. -->
<application
android:name="android.support.multidex.MultiDexApplication"
android:allowBackup="false"
tools:ignore="MissingApplicationIcon,HardcodedDebugMode"/>

Expand Down
2 changes: 2 additions & 0 deletions library/core/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@
<uses-permission android:name="android.permission.INTERNET"/>
<uses-sdk/>

<!-- TODO(b/243799715): Use android:name="androidx.multidex.MultiDexApplication" instead. -->
<application
android:name="android.support.multidex.MultiDexApplication"
android:allowBackup="false"
tools:ignore="MissingApplicationIcon,HardcodedDebugMode"
android:usesCleartextTraffic="true"/>
Expand Down
2 changes: 2 additions & 0 deletions library/datasource/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@
<uses-permission android:name="android.permission.INTERNET"/>
<uses-sdk/>

<!-- TODO(b/243799715): Use android:name="androidx.multidex.MultiDexApplication" instead. -->
<application
android:name="android.support.multidex.MultiDexApplication"
android:allowBackup="false"
android:usesCleartextTraffic="true"
tools:ignore="MissingApplicationIcon,HardcodedDebugMode">
Expand Down
2 changes: 2 additions & 0 deletions playbacktests/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@
<uses-permission android:name="android.permission.WAKE_LOCK"/>
<uses-sdk/>

<!-- TODO(b/243799715): Use android:name="androidx.multidex.MultiDexApplication" instead. -->
<application
android:name="android.support.multidex.MultiDexApplication"
android:allowBackup="false"
tools:ignore="MissingApplicationIcon,HardcodedDebugMode">
<activity android:name="com.google.android.exoplayer2.testutil.HostActivity"
Expand Down

0 comments on commit 142d1c0

Please sign in to comment.