Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set IPs and Ports for dev/production web app #23

Closed
DickChesterwood opened this issue May 16, 2018 · 1 comment
Closed

Set IPs and Ports for dev/production web app #23

DickChesterwood opened this issue May 16, 2018 · 1 comment

Comments

@DickChesterwood
Copy link
Owner

Usually, we avoid any references to IP addresses and ports anywhere in the code.

The exception is for the webapp, which as far as I can tell has no way of magically working out the IP/Domain and Port of the API gateway. Remember the webapp is Angular and therefore 100% client side.

The way I'm implementing this is: (there may be a better way, will learn about this over time)

  1. Angular client will get the IP address/domain of where it was served from (simple Javascript)
  2. We will standardise on port 8080 in production, and port 30000 for local-microservice.

This keeps things simple.

(there must be a better way!)

@DickChesterwood DickChesterwood added this to Release 1 in Releases May 16, 2018
DickChesterwood added a commit that referenced this issue May 16, 2018
@DickChesterwood
Copy link
Owner Author

I think this is there now, although I used 30040 for the front end due to 30000 not being available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant