unused variable rule shouldn't error on abstract methods with parameters

fixes palantir#663
DickvdBrink · Sep 16, 2015 · e636eb1 · e636eb1
1 parent b86e310
commit e636eb1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/rules/noUnusedVariableRule.ts b/src/rules/noUnusedVariableRule.ts
@@ -193,7 +193,13 @@ class NoUnusedVariablesWalker extends Lint.RuleWalker {
             }
         }
 
+        // skip checking parameter declarations for abstract methods
+        // They can't have a body so parameters are always unused
+        if (Lint.hasModifier(node.modifiers, ts.SyntaxKind.AbstractKeyword)) {
+            this.skipParameterDeclaration = true;
+        }
         super.visitMethodDeclaration(node);
+        this.skipParameterDeclaration = false;
     }
 
     private validateReferencesForVariable(name: string, position: number) {

diff --git a/test/files/rules/nounusedvariable-parameter.test.ts b/test/files/rules/nounusedvariable-parameter.test.ts
@@ -56,3 +56,7 @@ export class DestructuringTests {
         return;
     }
 }
+
+abstract class AbstractTest {
+    abstract foo(x);
+}