Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add restarting and pausing support #5

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

HarshNarayanJha
Copy link
Contributor

I gave implemented restarting the game without quitting and pausing logics. I have also added a flag on Diddi, called is_invicible, which disables any interaction with the Fire (for debugging purposes only!)

This commit has implemented restarting the game without quitting and pausing logics. This also includes an flag on `Diddi`, called is_invicible, which disables any interaction with the Fire (for debugging purposes only!)
@HarshNarayanJha
Copy link
Contributor Author

Oh! I accidently forgot to run black/flake8 formatter. It might have some issue!?

@DiddiLeija
Copy link
Owner

Since you're a "first-time contributor" in this repo, I have to approve GitHub workflow runs.
And... seems like flake8 isn't happy :/

Copy link
Owner

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest you these changes to get rid of flake8 issues. Haven't run local formatters yet, but I deduced the fix according to the flake8 error messages. Hope it helps 😄

main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
@DiddiLeija
Copy link
Owner

Anyway, thank you so much for providing an improvement like this!

main.py Show resolved Hide resolved
@DiddiLeija
Copy link
Owner

Hmm... Seems like now black is unhappy :/

@DiddiLeija
Copy link
Owner

Gonna try to run the formatters locally, to find a possible fix :)

@HarshNarayanJha
Copy link
Contributor Author

What's the issue this time 💦 ?

@DiddiLeija
Copy link
Owner

Black re-formatted something on my local run. Gonna make a suggestion as soon as possible 👍

main.py Outdated Show resolved Hide resolved
Co-authored-by: Diego Ramirez <dr01191115@gmail.com>
@HarshNarayanJha
Copy link
Contributor Author

Oh! Finally it did, Congrats 🎉

Copy link
Owner

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yipee! Thank you @HarshNarayanJha! 🎉

I've just tested this, and looks great. I'm going to merge this, update the guide with the new controls, and launch the fixed dists (we're still in time).

Thanks again!

@DiddiLeija DiddiLeija merged commit 26cd475 into DiddiLeija:main Nov 29, 2022
DiddiLeija added a commit that referenced this pull request Nov 29, 2022
Document the most recent options :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants