-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add restarting and pausing support #5
Conversation
This commit has implemented restarting the game without quitting and pausing logics. This also includes an flag on `Diddi`, called is_invicible, which disables any interaction with the Fire (for debugging purposes only!)
Oh! I accidently forgot to run black/flake8 formatter. It might have some issue!? |
Since you're a "first-time contributor" in this repo, I have to approve GitHub workflow runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest you these changes to get rid of flake8 issues. Haven't run local formatters yet, but I deduced the fix according to the flake8 error messages. Hope it helps 😄
Anyway, thank you so much for providing an improvement like this! |
Hmm... Seems like now black is unhappy :/ |
Gonna try to run the formatters locally, to find a possible fix :) |
What's the issue this time 💦 ? |
Black re-formatted something on my local run. Gonna make a suggestion as soon as possible 👍 |
Co-authored-by: Diego Ramirez <dr01191115@gmail.com>
Oh! Finally it did, Congrats 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yipee! Thank you @HarshNarayanJha! 🎉
I've just tested this, and looks great. I'm going to merge this, update the guide with the new controls, and launch the fixed dists (we're still in time).
Thanks again!
Document the most recent options :)
I gave implemented restarting the game without quitting and pausing logics. I have also added a flag on
Diddi
, calledis_invicible
, which disables any interaction with the Fire (for debugging purposes only!)