Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of CodeQL? #179

Closed
DiddiLeija opened this issue Dec 13, 2022 · 3 comments · Fixed by #182
Closed

Removal of CodeQL? #179

DiddiLeija opened this issue Dec 13, 2022 · 3 comments · Fixed by #182
Labels
type: enhancement New feature or request

Comments

@DiddiLeija
Copy link
Owner

Is your feature request related to a problem? Please describe.

CodeQL is the slowest step in our CI. And, thinking a bit further, it seems to be unecessary at the moment. So maybe it's just wasting time and space?

Describe the solution you'd like

Consider the removal of CodeQL setup.

Describe alternatives you've considered

Keep CodeQL, in case we'll need it soon.

Additional context

N/A
@DiddiLeija DiddiLeija added the type: enhancement New feature or request label Dec 13, 2022
@DiddiLeija
Copy link
Owner Author

Let's try this out :)

@DiddiLeija DiddiLeija linked a pull request Dec 27, 2022 that will close this issue
Remove CodeQL #182
Merged
@DiddiLeija DiddiLeija mentioned this issue Dec 27, 2022
Merged
@DiddiLeija
Copy link
Owner Author

#179 is a quick experiment of this proposal.

@DiddiLeija
Copy link
Owner Author

Ok, here's my resolution: let's remove CodeQL. But if DiddiParser 2 provides further feats where this scanning may be useful, we'll take CodeQL back :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove CodeQL DiddiLeija/diddiparser2
1 participant
@DiddiLeija