Conversation, goal, code and image fixes for later Area 51 starts #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would be good to have comments for these |
|
still waiting on comments to be added to these |
MQDuck
force-pushed
the
area51-conversations
branch
from
9ddd28d
to
f687e59
Compare
MQDuck
changed the title
Die4Ever
reviewed
Jun 6, 2024
Co-authored-by: Die4Ever <30947252+Die4Ever@users.noreply.github.com>
Die4Ever
reviewed
Jun 6, 2024
Die4Ever
reviewed
Jun 6, 2024
Die4Ever
reviewed
Jun 6, 2024
Die4Ever
reviewed
Jun 7, 2024
| if (dxr.localURL ~= _GetStartMap(starting_map)) { | ||
| switch(starting_map) { | ||
| case 152: | ||
| newGoal = p.AddGoal('KillPage', false); |
There was a problem hiding this comment.
could these be inside StartMapSpecificFlags?
|
this is probably all improvements with no regressions? probably ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.