Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space Travelers -- Missions -- Render fetched data #36

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

danifromecuador
Copy link
Collaborator

@danifromecuador danifromecuador commented Jul 27, 2023

In this pull request, I've:

  • Created a missions-render-data branch
  • Rendered missions data from the array stored in the store
  • Deleted hardcoded previous array
  • Overview:
    image

Copy link
Owner

@Diegogagan2587 Diegogagan2587 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED ✔️


Hi @danifromecuador ,

Your project is complete! Great job 🥇. There is nothing else to say other than... it's time to merge it 🍾🚢 :shipit: . Congratulations! 🎉💯🌟

wiserhood-cheers

To highlight 🍾

✅ All Linters are passing

✅ Hard coded array removed and render using store datat

✅ No inline styling

Optional suggestions:

  • You might move the logic within useEffect to the App.jsx component to fetch data only once.

Cheers, and Happy coding!👏👏👏.

Feel free to leave any questions or comments in the PR thread if something is not 100% Clear

@danifromecuador danifromecuador merged commit d56cc48 into development Jul 27, 2023
3 checks passed
@danifromecuador danifromecuador deleted the missions-render-data branch July 27, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants